Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nugets in .Tests and .TestingHarnessTest #2556

Closed
wants to merge 5 commits into from

Conversation

maw136
Copy link
Contributor

@maw136 maw136 commented Apr 19, 2023

Chore, update nugets in Tests and TestHarness.
Should have no impact on main dependencies of generated nugets.
Added necessary changes after nuget update

Fixes #2557

@maw136 maw136 changed the title chore: update nugets in Tests and TestHarness chore: update nugets in .Tests and .TestingHarnessTest Apr 19, 2023
@maw136 maw136 marked this pull request as draft April 19, 2023 20:34
@maw136 maw136 marked this pull request as ready for review April 19, 2023 22:04

public override void SetLength(long value) => throw new NotImplementedException();
public override long Seek(long offset, SeekOrigin origin) => throw new NotSupportedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all these C# changes caused by bumping Roslynator or how to they relate to the version bumps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These Stream based changes are strictly doc-based - no Roslynator detection there, maybe some async but I don't remember. I have posted link to Stream docs in commit description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted to separate PR

@maw136
Copy link
Contributor Author

maw136 commented May 29, 2023

Depends on:
#2593
#2591

@maw136 maw136 force-pushed the chore/update-nugets branch 2 times, most recently from 5e91bb6 to 572d3f7 Compare June 29, 2023 16:17
@mxschmitt
Copy link
Member

Closing for now since its stale.

@mxschmitt mxschmitt closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: update nuget dependencies in .Tests and ..TestingHarnessTest
2 participants